feat: audio track sink android implementation#10
Open
mdydek wants to merge 1 commit into
Open
Conversation
Author
|
@saghul have you had a chance to look at this pr? |
Member
|
Sorry, I somehow missed this, I'll take a look soon. Did you submit it upstream? |
Author
|
@saghul nope, could not, here is the explanation: react-native-webrtc/react-native-webrtc#1786 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Current webrtc android implementation has no logic of tapping to single audio stream on android
Solution
Implemented logic behind android audio tap similarly to
VideoSinkjava class andvideo_sinkc++ classes. As a skeleton code provided in react-native-webrtc/react-native-webrtc#1786 thread, by @davidliu was used (commit).