Skip to content

Don't escape processing instruction value in the format function.#3

Open
mkwiatkowski wants to merge 1 commit into
jinjor:masterfrom
mkwiatkowski:master
Open

Don't escape processing instruction value in the format function.#3
mkwiatkowski wants to merge 1 commit into
jinjor:masterfrom
mkwiatkowski:master

Conversation

@mkwiatkowski

@mkwiatkowski mkwiatkowski commented Nov 3, 2017

Copy link
Copy Markdown

With escaping enabled "format 10" test was failing with:

✗ format 10

    { processingInstructions = [{ name = "xml", value = "version="1.0"" }], docType = Nothing, root = Element "a" [] [] }
    ╷
    │ Expect.equal
    ╵
    { processingInstructions = [{ name = "xml", value = "version=\"1.0\"" }], docType = Nothing, root = Element "a" [] [] }

I made the simplest change that would pass all tests. Another approach would be to make ProcessingInstruction.value be a (String, Maybe String) tuple or perhaps a List Attribute, although that would be a breaking change.

With escaping enabled "format 10" test was failing with:

```
✗ format 10

    { processingInstructions = [{ name = "xml", value = "version="1.0"" }], docType = Nothing, root = Element "a" [] [] }
    ╷
    │ Expect.equal
    ╵
    { processingInstructions = [{ name = "xml", value = "version=\"1.0\"" }], docType = Nothing, root = Element "a" [] [] }
```
@mkwiatkowski

Copy link
Copy Markdown
Author

@jinjor Hi there, any chance of this being merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant