Don't escape processing instruction value in the format function.#3
Open
mkwiatkowski wants to merge 1 commit into
Open
Don't escape processing instruction value in the format function.#3mkwiatkowski wants to merge 1 commit into
format function.#3mkwiatkowski wants to merge 1 commit into
Conversation
With escaping enabled "format 10" test was failing with:
```
✗ format 10
{ processingInstructions = [{ name = "xml", value = "version="1.0"" }], docType = Nothing, root = Element "a" [] [] }
╷
│ Expect.equal
╵
{ processingInstructions = [{ name = "xml", value = "version=\"1.0\"" }], docType = Nothing, root = Element "a" [] [] }
```
Author
|
@jinjor Hi there, any chance of this being merged and released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With escaping enabled "format 10" test was failing with:
I made the simplest change that would pass all tests. Another approach would be to make
ProcessingInstruction.valuebe a(String, Maybe String)tuple or perhaps aList Attribute, although that would be a breaking change.