Skip to content

Fix parsing of escaped characters in attribute values#12

Open
hgoes wants to merge 1 commit into
jinjor:masterfrom
hgoes:master
Open

Fix parsing of escaped characters in attribute values#12
hgoes wants to merge 1 commit into
jinjor:masterfrom
hgoes:master

Conversation

@hgoes

@hgoes hgoes commented Dec 8, 2019

Copy link
Copy Markdown

The textString function discarded all text prior to an escaped
character. Example:
XmlParser.parse """<t attr="ABC&#253;DEF"/>""" => Ok { docType = Nothing, processingInstructions = [], root = Element "t" [{ name = "attr", value = "ýDEF" }] [] }

With the fix:

Ok { docType = Nothing, processingInstructions = [], root = Element "t" [{ name = "attr", value = "ABCýDEF" }] [] }

The textString function discarded all text prior to an escaped
character.
@miniBill

Copy link
Copy Markdown

This fixes #13

@dullbananas

Copy link
Copy Markdown

@jinjor please merge this

@miniBill

Copy link
Copy Markdown

(premise: thank you for writing this library, I appreciate that being an open source maintainer is a lot of work and people can have different priorities in life)

Do you expect you'll be able to merge this or should we fork the library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants