Skip to content

removed Fixnum reference#59

Open
sujangandikote wants to merge 1 commit into
jimweirich:masterfrom
sujangandikote:patch-1
Open

removed Fixnum reference#59
sujangandikote wants to merge 1 commit into
jimweirich:masterfrom
sujangandikote:patch-1

Conversation

@sujangandikote

Copy link
Copy Markdown

Fixnum and Bignum are combined into Integer class Since Ruby-2.4.0 release. This fix is to remove all Fixnum reference.

Fixnum and Bignum are combined into Integer class Since Ruby-2.4.0 release. This fix is to remove all Fixnum reference.
@hsbt

hsbt commented Feb 18, 2019

Copy link
Copy Markdown

@tenderlove Do you have a commit bit of this repository? I always get the warnings that are builder-2.1.2/lib/builder/xchar.rb:22: warning: constant ::Fixnum is deprecated when I invoked rubygems and bundler tests.

@tenderlove

Copy link
Copy Markdown

@hsbt no, but I have gem release access. Send the PR here: https://github.com/tenderlove/builder

@hsbt

hsbt commented Feb 18, 2019

Copy link
Copy Markdown

@tenderlove Thanks, I understood it.

@kbrock

kbrock commented Feb 19, 2024

Copy link
Copy Markdown

@sujangandikote looks like this has been merged in tenderlove. can we close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants