Updates + Fixes - #6
Open
tcyrus wants to merge 1 commit into
Open
Conversation
- Migrated to pyproject.toml
- Don't call get_everything if langcode is empty string
- Store get_code_data response instead of calling it 3 times
- Markup is no longer in flask (exported by markupsafe)
- migrated build_content and statblurb to Jinja2 macros
- Use window.location.origin for form submit redirect
- Use HTML escape characters for check and cross symbols
hub.toolforge.org can still fail because of rate limits.
I've made a basic GraphQL query which should be doing the same thing as the hub API:
query ($prop: PropertyId, $lang: String) {
searchItems(query: {property: $prop, value: $lang}, first: 1) {
edges {
node {
id
sitelink(siteId: "enwiki") {
url
}
}
}
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.tomlget_everythingiflangcodeis empty stringget_code_datainstead of calling it 3 times in a row (should fix Internal Server Error #4)Markupis no longer inflask. instead of addingmarkupsafeas a dependency, I migratedbuild_contentandstatblurbto Jinja2 macroswindow.location.origininstead of hardcoded URL for form submit (useful for local testing)