set overflow and maxlines limit to null if text is expanded, otherwis…#43
Open
veronikalaskova wants to merge 1 commit into
Open
set overflow and maxlines limit to null if text is expanded, otherwis…#43veronikalaskova wants to merge 1 commit into
veronikalaskova wants to merge 1 commit into
Conversation
…e use widget overflow/maxlines values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes getting maxLines value depending on whether text is expanded or not.
The current _maxLines method returns the value of 66 if the text widget is expanded and has an ellipsis overflow. This has 2 issues.
The fix sets maxLines to be null if the text is expanded, otherwise use maxLines which is passed in.