Skip to content

docs(rfc): flip RFCs 0040, 0041, 0042 to accepted — maintainer sign-off - #663

Merged
jensholdgaard merged 2 commits into
mainfrom
rfc-accepted-batch
Jul 27, 2026
Merged

docs(rfc): flip RFCs 0040, 0041, 0042 to accepted — maintainer sign-off#663
jensholdgaard merged 2 commits into
mainfrom
rfc-accepted-batch

Conversation

@jensholdgaard

@jensholdgaard jensholdgaard commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

Batch maintainer flip (2026-07-28): RFC 0040 (DataFusion operator instrumentation), RFC 0041 (dashboard datasource plugins), and RFC 0042 (typed numeric promotion) all move greenaccepted (terminal).

  • None of the three touches a benchmarks.md §7 pillar, so validated is vacuous — the RFC 0008 precedent — and green was each RFC's last verification stage.
  • RFC 0041's .5 recorded deferral survives acceptance unchanged: the latest e2e leg + wire-level sum land in ourios-perses-plugin when the next server release ships typed columns, tracked there rather than by reopening the RFC.
  • Roadmap: three ladder rows now read accepted TERMINAL; the "RFC 0040 → accepted" open-items bullet is closed.

Maintainer authorization: this session, 2026-07-28 ("lets do 1 and 2" — item 1 being these flips).

Verification

mdbook build clean. Docs-only; frontmatter status: fields flipped together with the banners (the #662 lesson).

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F

Summary by CodeRabbit

  • Documentation
    • Marked RFCs 0040, 0041, and 0042 as accepted following maintainer sign-off.
    • Updated RFC status notes with acceptance dates and verification details.
    • Refreshed the roadmap to reflect the completed acceptance of all three RFCs.
    • Clarified that RFC 0040 and RFC 0041 have reached terminal status.

Batch maintainer flip (2026-07-28). None of the three touches a
benchmarks.md §7 pillar, so validated is vacuous (RFC 0008 precedent)
and green was each RFC's last verification stage. RFC 0041's .5
recorded deferral survives acceptance and tracks in the plugin
repository. Roadmap ladder rows + open-items bullet updated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
@jensholdgaard
jensholdgaard requested a review from Copilot July 27, 2026 23:17
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 27b15a1e-1945-4034-82c5-faba12dd8007

📥 Commits

Reviewing files that changed from the base of the PR and between 17f2c1f and dd4a6d9.

📒 Files selected for processing (1)
  • docs/roadmap.md
📝 Walkthrough

Walkthrough

RFC 0040, RFC 0041, and RFC 0042 are marked accepted with sign-off details, and the roadmap is updated to reflect their terminal acceptance on 2026-07-28.

Changes

RFC acceptance documentation

Layer / File(s) Summary
RFC status and sign-off updates
docs/rfcs/0040-datafusion-operator-instrumentation.md, docs/rfcs/0041-dashboard-datasource-plugins.md, docs/rfcs/0042-typed-numeric-promotion.md
RFC metadata and status narratives now record accepted states, maintainer sign-off, and RFC-specific verification details.
Roadmap acceptance synchronization
docs/roadmap.md
The RFC ladder and open-work notes identify RFC 0040–0042 as accepted on 2026-07-28, with terminal wording for RFC 0040 and RFC 0041.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The summary is detailed, but the template's Related and Checklist sections are missing, so the required PR structure is incomplete. Add the missing Related section with issue/RFC links and include the checklist items for fmt, clippy, tests, docs, and RFC linkage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: flipping RFCs 0040–0042 to accepted with maintainer sign-off.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rfc-accepted-batch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates RFC documentation to reflect maintainer sign-off by flipping RFC 0040/0041/0042 from green to terminal accepted, and aligns the project roadmap accordingly.

Changes:

  • Flip RFC 0040, RFC 0041, and RFC 0042 frontmatter status: fields to accepted and add accepted status banners.
  • Update docs/roadmap.md ladder rows for RFCs 0040–0042 to accepted (terminal) and close the “RFC 0040 → accepted” open item.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docs/roadmap.md Marks RFC 0040/0041/0042 as accepted (terminal) in the roadmap and updates open items accordingly.
docs/rfcs/0040-datafusion-operator-instrumentation.md Flips RFC 0040 to accepted and records an accepted status banner.
docs/rfcs/0041-dashboard-datasource-plugins.md Flips RFC 0041 to accepted and records an accepted status banner (preserving the recorded deferral note).
docs/rfcs/0042-typed-numeric-promotion.md Flips RFC 0042 to accepted and records an accepted status banner referencing the live verification.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/rfcs/0040-datafusion-operator-instrumentation.md`:
- Line 4: Correct the premature July 28 acceptance dates and statuses across
docs/rfcs/0040-datafusion-operator-instrumentation.md (lines 4-4 and 14-19),
docs/rfcs/0041-dashboard-datasource-plugins.md (lines 4-20),
docs/rfcs/0042-typed-numeric-promotion.md (lines 4-4 and 14-17), and
docs/roadmap.md (lines 219-221 and 283-284). Use the actual sign-off date
consistently in RFC frontmatter, acceptance text, and roadmap completion notes,
or retain the pre-acceptance state until the flip is complete.

In `@docs/roadmap.md`:
- Around line 219-221: Complete the roadmap synchronization in
docs/roadmap.md:219-221 by updating the RFC 0040 downstream crate description
from “green” to its current accepted/terminal status, and in
docs/roadmap.md:283-284 update the RFC 0041 open-work bullet to remove its
“green” wording while retaining the RFC0041.5 deferral.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b62b97d-168d-44a8-a77c-8b9bf4f45136

📥 Commits

Reviewing files that changed from the base of the PR and between 4ea4d76 and 17f2c1f.

📒 Files selected for processing (4)
  • docs/rfcs/0040-datafusion-operator-instrumentation.md
  • docs/rfcs/0041-dashboard-datasource-plugins.md
  • docs/rfcs/0042-typed-numeric-promotion.md
  • docs/roadmap.md

Comment thread docs/rfcs/0040-datafusion-operator-instrumentation.md
Comment thread docs/roadmap.md
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
@jensholdgaard
jensholdgaard merged commit b0fb749 into main Jul 27, 2026
27 checks passed
@jensholdgaard
jensholdgaard deleted the rfc-accepted-batch branch July 27, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants