Fix build event payload serialization when job dates are null#27
Open
slayton wants to merge 1 commit into
Open
Fix build event payload serialization when job dates are null#27slayton wants to merge 1 commit into
slayton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
Build event payload creation can fail when
JobModelis serialized withoutcreatedDateorupdatedDatevalues. Those fields are only populated for item create/update events, but Jackson still calls their getters while serializing build events. The existing defensive-copy getters assumed the dates were non-null, causing aNullPointerExceptionand resulting in an empty HTTP request body.This change makes the
createdDateandupdatedDateaccessors null-safe while preserving defensive copies when values are present.Testing done
createdDateandupdatedDatevalues.git diff --check HEAD~1 HEAD.Submitter checklist