Skip to content

build(deps): upgrade ESLint 8→9, migrate to flat config#6

Merged
jdwillmsen merged 1 commit into
mainfrom
feat/eslint-v10-upgrade
May 27, 2026
Merged

build(deps): upgrade ESLint 8→9, migrate to flat config#6
jdwillmsen merged 1 commit into
mainfrom
feat/eslint-v10-upgrade

Conversation

@jdwillmsen
Copy link
Copy Markdown
Member

@jdwillmsen jdwillmsen commented May 27, 2026

Summary

  • Upgrades ESLint 8.57.1 → 9.39.4
  • Migrates all 18 .eslintrc.json files to eslint.config.ts flat config format
  • Adds globals package (replaces legacy env: { jest: true })
  • Updates nx.json namedInputs.production and targetDefaults[@nx/eslint:lint].inputs
  • Fixes accessibility violation in icon.component.html drop zone (surfaced by @angular-eslint 21.4.0 template rules)
  • No compat shim — clean break from eslintrc cascading model

Config structure

Root eslint.config.ts owns NX boundaries + TS/JS base. Each project imports and spreads root, then adds Angular selector rules. Four templates: Angular app, Angular lib, Angular lib+JSON dep-check, E2E/TS-only.

Test plan

  • nx run-many -t lint — all 21 projects pass (0 errors)
  • nx run-many -t lint --skip-nx-cache — no cache false-positives
  • nx format:check — clean
  • CI pipeline lint step passes

Closes JDWLABS-4

🤖 Generated with Claude Code

platform-e2e .eslintrc.json was deleted in the cleanup commit but
eslint.config.ts was never created. @angular-eslint 21.4.0 template
rules now surface two errors in icon.component.html -- added tabindex
and keydown.enter to make the drop zone keyboard-accessible.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 27, 2026

View your CI Pipeline Execution ↗ for commit c6dd58e

Command Status Duration Result
nx affected -t build ✅ Succeeded <1s View ↗
nx affected -t lint test ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-27 03:45:47 UTC

@jdwillmsen jdwillmsen merged commit a659e3a into main May 27, 2026
2 checks passed
@jdwillmsen jdwillmsen deleted the feat/eslint-v10-upgrade branch May 27, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant