docs: dedupe colliding PR templates (JDWLABS-32)#10
Merged
Conversation
The repo tracked both .github/PULL_REQUEST_TEMPLATE.md and .github/pull_request_template.md with different content. On case-insensitive filesystems only one exists on disk, so git permanently reports the other as modified — a trap that silently captures the phantom into 'git commit -a'. Remove the older lowercase duplicate and keep the canonical uppercase template, merging the lowercase extras into it (perf/ci/revert/style commit types and a 'no secrets in the diff' checklist item). Closes JDWLABS-32. Refs JDWLABS-22. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
View your CI Pipeline Execution ↗ for commit 2d9af0b
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The apps repo tracked two PR templates that collide on case-insensitive filesystems:
.github/PULL_REQUEST_TEMPLATE.mdand.github/pull_request_template.md(different content). On Windows only one exists on disk, so git permanently reports the other as modified — the phantom that silently got swept intogit commit -aearlier this session.Closes JDWLABS-32. Part of epic JDWLABS-22.
Changes
pull_request_template.md.PULL_REQUEST_TEMPLATE.md, merging the lowercase template's extras into it:perf/ci/revert/stylecommit types and a 'No secrets or credentials in the diff' checklist item.Verification
git ls-tree HEAD .github/shows a singlePULL_REQUEST_TEMPLATE.mdentry (case-sensitive remote view).🤖 Generated with Claude Code