ci: drop registry-url from the demo workflows - #661
Merged
Conversation
Neither demo workflow publishes to npm, but registry-url makes
setup-node write an .npmrc containing a ${NODE_AUTH_TOKEN} placeholder.
setup-node v6 also exported a dummy NODE_AUTH_TOKEN, so the placeholder
always resolved; v7 removed that dummy export (actions/setup-node#1558),
and yarn 1 hard-fails on an unresolvable env reference:
error Error: Failed to replace env in config: ${NODE_AUTH_TOKEN}
Dropping registry-url stops the .npmrc from being written at all, which
unblocks the setup-node v7 bump. mrml-wasm-release.yml keeps its
registry-url since it does publish, via OIDC trusted publishing.
Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
registry-urlfromexample-demo.ymlandexample-demo-test.yml.Why
Neither demo workflow publishes to npm, but
registry-urlmakessetup-nodewrite an.npmrccontaining a${NODE_AUTH_TOKEN}placeholder.setup-nodev6 also exported a dummyNODE_AUTH_TOKEN, so the placeholder always resolved. v7 removed that dummy export (actions/setup-node#1558), and yarn 1 hard-fails on an unresolvable env reference:That is what fails the
test building demojob on #658. Droppingregistry-urlstops the.npmrcfrom being written at all, which unblocks thesetup-nodev7 bump — and is the right config for these workflows regardless of the action version.mrml-wasm-release.ymlkeeps itsregistry-url: it does publish, vianpm publish --provenancewith OIDC trusted publishing, and npm does not choke on the unresolved placeholder the way yarn 1 does.