duty_cycle bug fixed - #1
Open
vnmtwo wants to merge 1 commit into
Open
Conversation
fixed duty-cycle bug: you cant set frequency, if old duty-cycle value is not valid for new frequency changed duty-cycle logic: now duty cycle in range in float 0.0 .. 1.0 and recalculates, depending of the frequency class attributes are private now the sysPWM class has constructor with frequency argument. I could not find a case, when I need an instance without frequency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed duty-cycle bug: you cant set frequency, if old duty-cycle value is not valid for new frequency
changed duty-cycle logic: now duty cycle in range in float 0.0 .. 1.0 and recalculates, depending of the frequency
class attributes are private now
the sysPWM class has constructor with frequency argument. I could not find a case, when I need an instance without frequency.