Add H900 learning - #80
Merged
Merged
Conversation
added 6 commits
May 2, 2026 12:34
tmp_pkt is three bytes too small and fails in Read(...). S nippet taken from "Write()" function, assuming same header size.
happens when deinit_concord() is called by the user code and the class destructor.
you can set a time and the remote will record all ir data for this time
Owner
|
I'm not overly worried about the newer C++ stuff, the fact we don't have it is just legacy. As long as it doesn't break any of the wrapping it into C-compat bindings, which I don't see how it would, I don't mind. I haven't looked deeply into the code, I'll review it when I get some time, but by and large at a quick scan it seems good. But can you update the SupporteModels.md accordingly? |
Owner
|
Also #81 will fix CI |
jaymzh
force-pushed
the
add-usbnet-learning
branch
from
May 8, 2026 18:22
7804948 to
17d7964
Compare
Owner
|
Also for the 1000, should we add retry if no data is returned? |
Owner
|
[rebased your PR to verify that it passes CI] |
Contributor
Author
The remote crashes and reboots, so i don't think that helps... |
martin-wagner
marked this pull request as ready for review
May 9, 2026 05:49
martin-wagner
force-pushed
the
add-usbnet-learning
branch
from
May 9, 2026 06:31
5b73344 to
9337ed3
Compare
jaymzh
reviewed
May 9, 2026
Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
approved these changes
Jul 10, 2026
jaymzh
enabled auto-merge (squash)
July 10, 2026 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds IR command learning for the Harmony 900. Please have a look before thinking about merging this. I intended to use this stand-alone when finding concordance had support for IR learning already, so this differs from the structure of the other code.
I've tried this with the 900 and 1000. 900 works perfectly, 1000 sometimes returns data, after that it crashes. When data is returned, it looks valid.