docs: correct MCP transport (SSE to streamable HTTP) and Claude Desktop config path#74
Merged
Merged
Conversation
…op config path The MCP server runs stateless streamable HTTP (api/services/mcp/server.py), but the README still described it as SSE in three places, contradicting its own MCP section and the code. This fixes the Features bullet, the architecture diagram, and the ports table. It also corrects the Claude Desktop config path to the macOS location (Library/Application Support/Claude) with an explicit macOS/Windows split, and updates two stale SSE comments in api/main.py and api/routers/mcp.py so the code matches the transport it mounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Corrects the MCP transport description in the README, which still called it SSE in three places even though the server runs stateless streamable HTTP (
api/services/mcp/server.py— it deliberately abandoned SSE because the stream died onuvicorn --reload). The README's own MCP section already said "streamable HTTP," so the three stale references were internally inconsistent with both the code and the rest of the doc.README.mdREST + MCP/SSE→REST + MCP/HTTPREST + MCP/SSE→REST + MCP/HTTP~/.config/claude/…to the macOS location~/Library/Application Support/Claude/claude_desktop_config.json, with an explicit macOS / Windows splitapi/main.pyandapi/routers/mcp.pyWhy
Documentation-accuracy follow-up. A reader wiring up an MCP client would otherwise get contradictory signals about the transport, and the macOS config path pointed at a directory Claude Desktop does not use.
Reviewer notes
FastMCP(..., stateless_http=True, json_response=True)inapi/services/mcp/server.py).http://localhost:8000/docs(returns 200 on the live stack).ruffpasses on the two edited Python files; mypy/pytest are not meaningful for comment-only edits.origin/main..HEADis exactly this one commit, so the PR diff is just these fixes.