Menno's updated branch pull request - #48
Open
MennoLaveaux wants to merge 4 commits into
Open
Conversation
Added the GNU General Public License version 3 to the project.
Add a comprehensive .gitignore file for Python projects
jatkinson1000
requested changes
Jul 16, 2026
jatkinson1000
left a comment
jatkinson1000
left a comment
Owner
There was a problem hiding this comment.
Thanks @MennoLaveaux This is a great start to the PR, linking to the issue you opened.
I have made a "suggestion" in my code review that you can try merging into your code using the GitHub Pull Request interface.
I also see we have all of the other files from the workshop creeping in.
Ideally these would be on other branches so that only the new equation is being contributed here. The intermediate git course would give you some clues on how to clean this up ;)
| Calculate pendulum length from the period. | ||
| """ | ||
| return m * 9.81 * max_height(len, theta) | ||
| return 9.81 * period**2 /(4 * np.pi**2) |
Owner
There was a problem hiding this comment.
This might be a bit clearer and more concise:
Suggested change
| return 9.81 * period**2 /(4 * np.pi**2) | |
| return 9.81 * (period / (2.0 * np.pi)) ** 2.0 |
| ------- | ||
| float | ||
| energy [kg . m2 /s2] of the pendulum | ||
| Calculate pendulum length from the period. |
Owner
There was a problem hiding this comment.
Perhaps we could extend the docstring here to conform to numpy style?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the solution to Issue #37 .
Cool stuff!