added an equation for length from period - #45
Open
jvynn wants to merge 1 commit into
Open
Conversation
jatkinson1000
approved these changes
Jul 16, 2026
jatkinson1000
left a comment
jatkinson1000
left a comment
Owner
There was a problem hiding this comment.
Thanks @jvynn this is a great PR, linking to the issue you opened.
I have made a "suggestion" in my code review that you can try merging into your code using the GitHub Pull Request interface.
| float | ||
| length [m] of the pendulum | ||
| """ | ||
| return (period / (2.0 * np.pi)) ** 2 * 9.81 |
Owner
There was a problem hiding this comment.
Consider moving the 9.81 to the front to be a little more clear when reading that it is not part of the exponent.
Suggested change
| return (period / (2.0 * np.pi)) ** 2 * 9.81 | |
| return 9.81 * (period / (2.0 * np.pi)) ** 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is addressing issue #32.
It adds an equation for length of pendulum from period