WIP: configurable body parser - #37
Draft
jech wants to merge 2 commits into
Draft
Conversation
Also add error handling, in preparation for customisable payloads.
jech
marked this pull request as ready for review
June 24, 2026 15:35
jech
marked this pull request as draft
June 24, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDP parser in gosip is very limited, and is only suitable for a single audio flow. Since we don't want to spend the rest of our lives working on SDP, this makes the body parser configurable, so that we can use the Pion implementation of SDP instead of gosip's.
This breaks compatibility, since it adds an error return to the
Datamethod ofPayload. While I was breaking compatibility, I renamed theDatamethod toMarshal, for consistency with Pion. @jart please let me know if you object, it is possible to retain compatibility at the cost of deficient error handling.Most of gosip should work with Pion's implementation of SDP, but I haven't tested yet. There are unfortunately two places that hard-wire a dependency on gosip's SDP:
rtp/session.goanddialog/dialog.go. The former is not an issue. The latter is, and I don't see a good idea for fixing it.