Improve meson setup#202
Open
QuLogic wants to merge 3 commits into
Open
Conversation
It is recommended [1] to not use (enable|disable) prefix on option names, as this is not autoconf. [1] https://mesonbuild.com/Style-guide.html#naming-options
* Packages that provide a pkg-config file or are supported by Meson should use `dependency`, not `find_library`. * Both `dl` and `m` are glibc-specific, and should be optional in order to build on other systems.
Set `cpp_std` as a build option, use `include_directories`, and enable hidden symbol visiblity again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A variety of things to update and modernize the Meson setup. It would also be good to set a minimum Meson version in your
projectcall, as there are other things that could be done, but I wasn't sure if it would be too new.It is recommended to not use (enable|disable) prefix on option names, as this is not autoconf.
dependency, notfind_library.dlandmare glibc-specific, and should be optional in order to build on other systems.cpp_stdas a build option, useinclude_directories, and enable hidden symbol visibility again.I would also say you should explicitly list out the files instead of using
find, but you do that so much I didn't want to do that out of the blue.