Conversation
OwenDurkin
reviewed
Aug 2, 2021
OwenDurkin
left a comment
OwenDurkin
left a comment
Collaborator
There was a problem hiding this comment.
General feedback, some suggestions, and potential bug identifications.
| strcpy(FILENAME_BUFFER.buf, "unnamed.txt"); | ||
|
|
||
|
|
||
| HINT_TEXT_QUEUE = calloc(8192, sizeof(char*)); |
Collaborator
There was a problem hiding this comment.
Arbitrary buffer sizes aren't great but I understand that we might hack it until we get a more permanent solution in. All the same, 8192 is a magic number here- would be better to put it in a static const variable. Again, the more permanent solution would be to re-use the data structures that we have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is now a cursor when editing text, that you can move around with the arrow keys, and zooming now works with - and =.
Yes these should have been two different PRs.