Add C-implementation for builds on stable rust#24
Open
bossmc wants to merge 2 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asm!is still a way from being stabilised, but it would be really useful to use this crate on stable (though unsafe) rust.This PR adds a
build.rswhich detects if you're on stable/beta vs nightly and uses GCC to compile thesyscall<n>functions from small C snippets (using__asm__). The C code is, well should be, equivalent to the rust code, though I've not been able to test on any platform other than x86_64 linux.A minor disadvantage, the C functions can't easily be inlined (though I suspect LTO might be able to).
Platform support (compared to the rust implementations):