Review src/menu.h comments#263
Merged
Merged
Conversation
Apply the approved menu.h comment review updates from the branch-target review run. What changed: - tightened several member and helper comments around bitmap scaling, MenuBar activation, popup traversal, and image list propagation - clarified the TrackInternal parameter note so the added inputs are aligned visually and described more directly - refined the GetItemRect comment to state explicitly that it returns the item rectangle in screen coordinates Why it changed: - the updated wording is more precise and easier to scan in English while preserving the existing menu behavior and API intent - the change remains strictly comment-only in a header that otherwise reviewed cleanly How the result was verified: - completed the branch-target review pipeline through scan, ground, review, resolve, apply, guard, and HTML generation with full prompt logging - reran guard on the delivery branch checkout and confirmed zero violations in strict and ignore-whitespace modes - checked git diff --check and the final comment-only diff for src/menu.h before committing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification