Skip to content

Review src/md5.cpp comments #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janrysavy merged 1 commit into from
Apr 8, 2026
Merged

Review src/md5.cpp comments #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/md5.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ void MD5::update(uint1* input, uint4 input_length)
uint4 buffer_space; // how much space is left in buffer

if (finalized)
{ // so we can't update!
{ // cannot update after finalization
TRACE_E("MD5::update: Can't update a finalized digest!");
return;
}
Expand All @@ -45,7 +45,7 @@ void MD5::update(uint1* input, uint4 input_length)

// Transform as many times as possible.
if (input_length >= buffer_space)
{ // ie. we have enough to fill the buffer
{ // i.e. we have enough data to fill the buffer
// fill the rest of the buffer and transform
memcpy(buffer + buffer_index, input, buffer_space);
transform(buffer);
Expand Down Expand Up @@ -118,9 +118,9 @@ void MD5::init()
state[3] = 0x10325476;
}

// Constants for MD5Transform routine.
// Although we could use C++ style constants, defines are actually better,
// since they let us easily evade scope clashes.
// Constants for the MD5Transform routine.
// Although we could use C++-style constants, `#define`s are actually better,
// since they let us easily avoid scope clashes.

#define S11 7
#define S12 12
Expand Down
Loading