Review src/usermenu.h comments#257
Merged
Merged
Conversation
Apply the reviewed usermenu.h comment wording from the branch-target sequential review run. What changed: - clarified that the background icon reader stop flag means icon reading has stopped because the main window has already closed or is closing - replaced popup wording with submenu wording for the submenu begin and end enum markers - tightened several helper comments around icon retrieval and hotkey parsing to read more directly while preserving the documented behavior Why it changed: - the approved review output improves readability and consistency of the user menu comments without changing code behavior - the updated wording better matches the actual menu concepts used by the surrounding declarations How the result was verified: - completed the full branch-target sequential review pipeline through HTML - confirmed comment guard passes with zero violations in strict and ignore-whitespace modes - checked the resulting git diff and git diff --check for src/usermenu.h before committing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification