Review src/tooltip.cpp comments#255
Merged
Merged
Conversation
Apply the reviewed comment-only fixes for src/tooltip.cpp. This commit updates five tooltip timing and state comments. The delay constants now use more natural English around being over a single ID in one window, hiding the tooltip, and waiting before entering the Killed state. The GetText() early-exit note now says that the code hides the previous tooltip and exits, which is shorter and clearer than the earlier bail-out phrasing. The timer comment now states directly that the root window must also be active. The branch-target artifact for src/tooltip.cpp completed scan, AST grounding, provider review, resolve, apply, comment guard, and HTML generation with full prompt logging. The approved draft was then applied into the delivery branch checkout, the resulting git diff was inspected to confirm that only src/tooltip.cpp changed, and comment guard was rerun against the branch worktree to verify that the committed state still has no non-comment edits. Verification: - artifacts/src-tooltip-cpp-review-20260408-run1/comment-guard-report.json shows 0 violations for src/tooltip.cpp - artifacts/src-tooltip-cpp-review-20260408-run1/reviewed.patch matches the applied branch diff - git diff --check -- src/tooltip.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/tooltip.cppVerification
node --experimental-strip-types src/cli.ts guard --target-root /mnt/d/Source/OpenSal/salamander_codex_src_20260408 --translation-source /mnt/d/Source/OpenSal/salamander_codex_src_20260408 --baseline-source /mnt/d/Source/OpenSal/salamander_upstream --artifacts-dir /mnt/d/Source/OSTranslation/artifacts/src-tooltip-cpp-review-20260408-run1 --file src/tooltip.cpp --cost-profile cheap-first --review-provider auto --copilot-model gpt-5.4 --copilot-reasoning high --prompt-log-mode full --include-audit-onlygit -C /mnt/d/Source/OpenSal/salamander_codex_src_20260408 diff --check -- src/tooltip.cpp