fix(schema): rebuild aggregation index on upgrade#670
Open
janbjorge wants to merge 1 commit into
Open
Conversation
The aggregation index change in #668 edited an existing upgrade yield in place, flipping ((1)) to the composite while keeping CREATE INDEX IF NOT EXISTS. On existing deployments the index name already exists, so the statement is a no-op and the composite is never built -- the WHERE NOT aggregated speedup reaches only fresh installs. Restore the historical yield to ((1)) and append a DROP INDEX IF EXISTS plus CREATE composite step, following the append-only idempotent migration pattern. Install DDL is unchanged (already composite). Add a regression test that seeds the legacy ((1)) index, runs upgrade, and asserts the index is rebuilt as the composite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aggregation index change in #668 edited an existing upgrade yield in place, flipping ((1)) to the composite while keeping CREATE INDEX IF NOT EXISTS. On existing deployments the index name already exists, so the statement is a no-op and the composite is never built -- the WHERE NOT aggregated speedup reaches only fresh installs.
Restore the historical yield to ((1)) and append a DROP INDEX IF EXISTS plus CREATE composite step, following the append-only idempotent migration pattern. Install DDL is unchanged (already composite).
Add a regression test that seeds the legacy ((1)) index, runs upgrade, and asserts the index is rebuilt as the composite.
Summary
Testing
make checkpassedChecklist