(PUP-6295) Acceptance test for corrective_change flag#1
Open
sheenaajay wants to merge 1 commit into
Open
Conversation
| require 'puppet/acceptance/environment_utils' | ||
| extend Puppet::Acceptance::EnvironmentUtils | ||
|
|
||
| app_type = File.basename(__FILE__, '.*') |
Owner
There was a problem hiding this comment.
The name "app_type" isn't self-descriptive. I think it was used in the existing test code by mistake. It should be changed to something more self-descriptive. I think this variable stores the name of this test file... so possibly rename this to "test_file_name"?
Author
There was a problem hiding this comment.
Thank you James for the valuable comments.
The comment is incorporated to the file
test_file_name = File.basename(FILE, '.*')
tmp_environment = mk_tmp_environment_with_teardown(master, test_file_name)
sheenaajay
force-pushed
the
PUP-6295_acceptance
branch
from
8fa7202 to
a5d6993
Compare
Thie commit adds new acceptance test for corrective_change flag [skip ci]
sheenaajay
force-pushed
the
PUP-6295_acceptance
branch
from
a5d6993 to
b643f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thie commit adds new acceptance test for corrective_change flag
[skip ci]