Conversation
| <!-- default is the same for backward compatibility reason | ||
| Easy to override when building with a system property --> | ||
| <spec.version>1.0</spec.version> | ||
| <spec.version>1.1</spec.version> |
There was a problem hiding this comment.
Could it be derived from project.version to not need to be updated manually?
There was a problem hiding this comment.
Can we use the semantic version, e.g.: 1.1.0, instead of the one required to Jakarta EE spec, e.g.: 1.1?
The last time we did that, we had to roll back.
There was a problem hiding this comment.
I've not asked to use project.version but to extract major.minor from it.
There was a problem hiding this comment.
I usually use the spec version separately from the project version to be able to build snapshots and miletones. But it is probably because of how the spec version plugin is set up. How you do it is totally up to you. The result should be the same with major.minor in the spec documents
There was a problem hiding this comment.
I got it @pzygielo how about now?
Thank you @ivargrimstad
There was a problem hiding this comment.
how about now?
For me - perfect 🎆
This pull request updates the Maven build configuration in
spec/pom.xmlto improve version management by dynamically setting the specification version and introducing a new plugin for parsing version information.Build and versioning improvements:
spec.versionproperty is now set dynamically using the parsed major and minor version numbers from the project version, instead of being hardcoded.build-helper-maven-plugin(version 3.6.1) with theparse-versiongoal to the build plugins, enabling automatic extraction of version components for use in properties.