Skip to content

Update spec.version to 1.1 in pom.xml#1425

Open
otaviojava wants to merge 3 commits intomainfrom
update-spec-doc-version
Open

Update spec.version to 1.1 in pom.xml#1425
otaviojava wants to merge 3 commits intomainfrom
update-spec-doc-version

Conversation

@otaviojava
Copy link
Copy Markdown
Contributor

@otaviojava otaviojava commented Apr 15, 2026

This pull request updates the Maven build configuration in spec/pom.xml to improve version management by dynamically setting the specification version and introducing a new plugin for parsing version information.

Build and versioning improvements:

  • The spec.version property is now set dynamically using the parsed major and minor version numbers from the project version, instead of being hardcoded.
  • Added the build-helper-maven-plugin (version 3.6.1) with the parse-version goal to the build plugins, enabling automatic extraction of version components for use in properties.

Comment thread spec/pom.xml Outdated
<!-- default is the same for backward compatibility reason
Easy to override when building with a system property -->
<spec.version>1.0</spec.version>
<spec.version>1.1</spec.version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be derived from project.version to not need to be updated manually?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the semantic version, e.g.: 1.1.0, instead of the one required to Jakarta EE spec, e.g.: 1.1?

The last time we did that, we had to roll back.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not asked to use project.version but to extract major.minor from it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use the spec version separately from the project version to be able to build snapshots and miletones. But it is probably because of how the spec version plugin is set up. How you do it is totally up to you. The result should be the same with major.minor in the spec documents

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it @pzygielo how about now?

Thank you @ivargrimstad

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about now?

For me - perfect 🎆

@otaviojava otaviojava requested review from KyleAure and njr-11 April 17, 2026 03:03
@otaviojava
Copy link
Copy Markdown
Contributor Author

@njr-11 @KyleAure could you review this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants