Avoid ambiguity in dataStore name requirements#1406
Open
njr-11 wants to merge 2 commits intojakartaee:mainfrom
Open
Avoid ambiguity in dataStore name requirements#1406njr-11 wants to merge 2 commits intojakartaee:mainfrom
njr-11 wants to merge 2 commits intojakartaee:mainfrom
Conversation
gavinking
reviewed
Mar 19, 2026
Comment on lines
+110
to
+111
| * <p>Jakarta Data providers that access a relational database via JDBC | ||
| * must accept the following as the {@code dataStore} value: |
Member
There was a problem hiding this comment.
I think I know what you're trying to say here, but since JPA implementations usually use JDBC to access the database, this is still slightly ambiguous.
You could maybe reverse the order of the cases and say "Other Jakarta Data providers that access a relational database via JDBC".
Member
Author
There was a problem hiding this comment.
Good idea. And we would probably rather have the JPA information show up first regardless. I added a commit to switch it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed on today's Jakarta Data call. Javadoc for
@Repository(dataStore = ...)has some ambiguity in the requirements for relational databases that could be interpreted to mean that Jakarta Data providers that access the database via JDBC vs Jakarta Persistence might need to support all of the possible types of names/JNDI names. This PR splits the single list into 2 separate lists for better clarity. It also elaborates on what is meant by the JNDI name of an EntityManagerFactory (recently added in Jakarta Persistence) vs a persistence unit reference JNDI name, which was also mentioned during the meeting.