fix: atomic config swap — no panic, router/middleware always consistent - #8
Open
notr3kt wants to merge 1 commit into
Open
fix: atomic config swap — no panic, router/middleware always consistent#8notr3kt wants to merge 1 commit into
notr3kt wants to merge 1 commit into
Conversation
- Store handlers in a stable handlerHolder so atomic.Value never panics when swapping HandlerFunc -> ServeMux on first reload - Rebuild full mux from one config snapshot, then publish under lock - Collapse concurrent provider bursts to latest config (no partial merge) - Deep-copy GetConfig() so API readers cannot race writers - Add race-detector tests for first-swap panic and body/header consistency - Add CI with go test -race Closes jahmeergnlt#1
5 tasks
|
👀 We've notified the reward creators here. |
Author
|
Friendly bump for review when you have a moment.
Happy to iterate on any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1.
Configuration reloads from concurrent providers could:
atomic.Valuetype mismatch:HandlerFunc→*ServeMux)Fix
handlerHolderwrapper soatomic.Valuealways stores one concrete typeGetConfig()returns deep copiesTests
go test ./... -race -count=3TestFirstConfigSwapDoesNotPanicTestConfigAndHandlerStayConsistent(2000 reqs under dual providers)TestGetConfigDeepCopyClaim
/claim #1