fix(server): resolve atomic value panic during config swap - #7
Open
parastejpal987-cmyk wants to merge 1 commit into
Open
fix(server): resolve atomic value panic during config swap#7parastejpal987-cmyk wants to merge 1 commit into
parastejpal987-cmyk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a concurrency panic that occurs when
atomic.Valueattempts to store a different concrete type than what was initially stored.Why is it necessary?
During rapid configuration reloads, the underlying type of the HTTP handler being stored in
server.gocould sometimes vary between differenthttp.Handlerimplementations. Go'ssync/atomic.Valuepanics if you try to store a value of a different concrete type than the first one stored.How does it work?
Introduced a
handlerWrapperstruct to encapsulate the handler. By storing the wrapper instead of the raw handler,atomic.Valuealways receives the exact same concrete type, safely avoiding the panic while swapping configurations.