Enable Configurable Maximum Buffer Size for FUSE Messages#194
Open
abhishek10004 wants to merge 1 commit into
Open
Enable Configurable Maximum Buffer Size for FUSE Messages#194abhishek10004 wants to merge 1 commit into
abhishek10004 wants to merge 1 commit into
Conversation
| if cfg.MaxMessageSize > 0 { | ||
| maxPayload = max(maxPayload, int(cfg.MaxMessageSize)) | ||
| } | ||
| c.inMessageSize = maxPayload + buffer.GetPageSize() |
There was a problem hiding this comment.
should we add this pageSize() inside in_message.go constructor? that way we can avoid subtracting for maxWrite.
you can also rename this parameter to maxPayload
vadlakondaswetha
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded 1 MiB limit for FUSE message buffers in jacobsa/fuse and makes it configurable via MountConfig. This is necessary to support larger kernel requests (e.g., 16 MiB) without triggering buffer overflows that result in 0-byte reads and premature EOFs. (Also, we're still keep the minimum buffer size value to 1MiB which is still the default value)