Return error on oversized read requests in convertInMessage#191
Closed
kislaykishore wants to merge 0 commit into
Closed
Return error on oversized read requests in convertInMessage#191kislaykishore wants to merge 0 commit into
kislaykishore wants to merge 0 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the kernel requests a read size larger than the available buffer space in
convertInMessage,inMsg.GetFreereturns nil. Previously, this could lead to a panic or silent failure.This change adds a check to explicitly return an error ("Cannot allocate read buffer") if the requested size is greater than 0 but no buffer could be allocated.