feat(core): make rate-limit retry ceiling configurable - #281
Merged
jacob-bd merged 1 commit intoAug 5, 2026
Merged
Conversation
b0ch3nski
reviewed
Aug 5, 2026
| NOTEBOOKLM_MCP_DEBUG Debug logging (default: false) | ||
| NOTEBOOKLM_HL Interface language and default artifact language (default: en) | ||
| NOTEBOOKLM_QUERY_TIMEOUT Query timeout in seconds (default: 120.0) | ||
| NOTEBOOKLM_RATE_LIMIT_MAX_RETRIES Retry count for HTTP 429/RPC resource limits (default: 3; 0 disables) |
There was a problem hiding this comment.
nitpick: messes the indentation of variable descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
NOTEBOOKLM_RATE_LIMIT_MAX_RETRIESso callers that own queueing or backoff can choose how many automatic rate-limit retries the client performs.Behavior
DEFAULT_MAX_RETRIESbehavior0: surface HTTP 429 and RPCRESOURCE_EXHAUSTEDimmediatelyThe setting applies only to rate limits. HTTP 5xx recovery, connection retries, and authentication recovery retain their existing behavior. Direct HTTP and CDP transports use the same policy.
Motivation
External orchestrators often need to own retry timing globally. Without a rate-limit-specific ceiling, the client and the outer queue can both back off, increasing latency and making scheduling nondeterministic.
Compatibility
Default behavior is unchanged and no dependencies are added.
Validation
uv run ruff check .uv run ruff format --check .Rate-limit branches were exercised with deterministic HTTP/RPC responses, including separation from 5xx and connection retry paths. A real account was not intentionally driven into a quota failure.