fix(windows): resolve Claude config without environment home - #278
Merged
jacob-bd merged 1 commit intoAug 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.home()cannot resolveAppData\RoamingandAppData\LocalfallbacksPath.home()behavior when those sources are availableProblem
_claude_desktop_candidate_paths()currently callsPath.home()afterAPPDATA/LOCALAPPDATAare absent. On Windows, clearing the environment can makePath.home()raiseRuntimeError: Could not determine home directory, including in the existingtest_windows_path_falls_back_when_appdata_is_missingcase.Implementation
The fallback order is:
Path.home()SHGetFolderPathW(CSIDL_PROFILE)SYSTEMDRIVE\Users\<os.getlogin()>The helper raises the original
Path.home()error when no reliable Windows profile path can be resolved.Validation
uv run ruff check .uv run ruff format --check .uv run pytest tests/cli/test_setup_claude_desktop.py -q— 39 passedManual Windows reproduction: with home-related environment variables cleared, Claude Desktop config-path resolution returns a profile-based path instead of raising from
Path.home().No new dependencies.