Skip to content

Add dedicated session attribute errors #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adriansmares wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −5
Open

Add dedicated session attribute errors #2635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions pgconn/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,6 +1067,17 @@ func makeConnectTimeoutDialFunc(timeout time.Duration) DialFunc {
return d.DialContext
}

var (
// ErrReadOnlyConnection is returned when a read-write connection is required but the connection is read-only.
ErrReadOnlyConnection = errors.New("read only connection")
// ErrReadWriteConnection is returned when a read-only connection is required but the connection is read-write.
ErrReadWriteConnection = errors.New("connection is not read only")
// ErrPrimaryConnection is returned when a standby connection is required but the server is primary.
ErrPrimaryConnection = errors.New("server is not in hot standby mode")
// ErrStandbyConnection is returned when a primary connection is required but the server is in standby mode.
ErrStandbyConnection = errors.New("server is in standby mode")
)

// ValidateConnectTargetSessionAttrsReadWrite is a ValidateConnectFunc that implements libpq compatible
// target_session_attrs=read-write.
func ValidateConnectTargetSessionAttrsReadWrite(ctx context.Context, pgConn *PgConn) error {
Expand All @@ -1076,7 +1087,7 @@ func ValidateConnectTargetSessionAttrsReadWrite(ctx context.Context, pgConn *PgC
}

if string(result[0].Rows[0][0]) == "on" {
return errors.New("read only connection")
return ErrReadOnlyConnection
}

return nil
Expand All @@ -1091,7 +1102,7 @@ func ValidateConnectTargetSessionAttrsReadOnly(ctx context.Context, pgConn *PgCo
}

if string(result[0].Rows[0][0]) != "on" {
return errors.New("connection is not read only")
return ErrReadWriteConnection
}

return nil
Expand All @@ -1106,7 +1117,7 @@ func ValidateConnectTargetSessionAttrsStandby(ctx context.Context, pgConn *PgCon
}

if string(result[0].Rows[0][0]) != "t" {
return errors.New("server is not in hot standby mode")
return ErrPrimaryConnection
}

return nil
Expand All @@ -1121,7 +1132,7 @@ func ValidateConnectTargetSessionAttrsPrimary(ctx context.Context, pgConn *PgCon
}

if string(result[0].Rows[0][0]) == "t" {
return errors.New("server is in standby mode")
return ErrStandbyConnection
}

return nil
Expand All @@ -1136,7 +1147,7 @@ func ValidateConnectTargetSessionAttrsPreferStandby(ctx context.Context, pgConn
}

if string(result[0].Rows[0][0]) != "t" {
return &NotPreferredError{err: errors.New("server is not in hot standby mode")}
return &NotPreferredError{err: ErrPrimaryConnection}
}

return nil
Expand Down