You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had a scenario where I needed to also specify custom arguments to the git fetch command, in addition to git clone. This wasn't supported, so I've added it as just another YAML option.
Pretty much just copied the implementation of user_params in most places.
Tests run and all but 3 succeed, which is how many failed when I ran them before these changes.
Then perhaps this feature can start by sharing params configuration option and passing it to both clone and fetch, which have many of the same options.
I could also see people wanting --prune, or --verbose
I think I would rather see those as command-line options passed to gitman rather than stored in the configuration file. gitman -v2 could make git more verbose, for example.
Then perhaps this feature can start by sharing params configuration option and passing it to both clone and fetch, which have many of the same options.
While they do share some parameters, there are many that they also don't share.
I did a diff on the options from the manual (it's not perfect, but it's close enough): https://www.diffchecker.com/iGgPsZWj
I think I would rather see those as command-line options passed to gitman rather than stored in the configuration file. gitman -v2 could make git more verbose, for example.
That makes sense to me. Could pass that down to everything applicable, which might make debugging easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a scenario where I needed to also specify custom arguments to the
git fetchcommand, in addition togit clone. This wasn't supported, so I've added it as just another YAML option.Pretty much just copied the implementation of
user_paramsin most places.Tests run and all but 3 succeed, which is how many failed when I ran them before these changes.