Upgrade project to Rust 2024 edition - #4
Merged
Conversation
- Set `edition = "2024"` in `Cargo.toml` files for all workspace members. - Added `resolver = "3"` in the root `Cargo.toml`. - Replaced the stabilized `slice_group_by` nightly feature with the standard `chunk_by` method. - Replaced the `assert_matches` nightly feature with the `assert_matches` external crate to fix API changes. Co-authored-by: jac3km4 <11986158+jac3km4@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `.github/workflows/ci.yml` based on the requested template. - Adjusted the CI workflow to install `clang` and `libclang-dev` required by `clang-sys`. - Used `nightly` toolchain for all CI jobs since the project requires unstable Rust features (e.g., `#![feature(iter_advance_by)]`). Co-authored-by: jac3km4 <11986158+jac3km4@users.noreply.github.com>
- Updated `.github/workflows/ci.yml` to specify `--default` in the `rustup toolchain install nightly` steps to ensure `cargo test` and `cargo clippy` use the nightly compiler, fixing `#![feature]` errors. - Formatted `saltwater/src/main.rs` and `saltwater/src/resolver.rs` by running `cargo +nightly fmt --all` to fix formatting failures in CI. Co-authored-by: jac3km4 <11986158+jac3km4@users.noreply.github.com>
- Removed the invalid `--default` flag from the `rustup toolchain install` commands in `.github/workflows/ci.yml`. - Replaced `cargo test`, `cargo clippy`, and `cargo fmt` with `cargo +nightly test`, `cargo +nightly clippy`, and `cargo +nightly fmt` in CI, to ensure the nightly compiler is used and `#![feature]` errors do not occur. Co-authored-by: jac3km4 <11986158+jac3km4@users.noreply.github.com>
- Fixed `clippy::unnecessary-cast` by removing `as i64` from `spec.offset.unwrap_or(0)` in `core/src/symbols.rs`. - Fixed `clippy::useless-conversion` by removing `.into_iter()` call in `core/src/spec.rs`. - Fixed `clippy::suspicious-double-ref-op` by replacing `str.deref().to_owned()` with `(*str).to_owned()` in `core/src/spec.rs`. - Fixed `clippy::map-entry` by replacing `.contains_key()` check followed by `.insert()` with `.entry().or_insert_with()` in `saltwater/src/resolver.rs`. - Bypassed `clippy::collapsible-if` in `clang/src/main.rs` and `saltwater/src/main.rs` with `#[allow(clippy::collapsible_if)]` to avoid introducing the unstable `let_chains` feature, which previously caused compilation failures. Co-authored-by: jac3km4 <11986158+jac3km4@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the workspace to Rust 2024 and resolves compilation issues due to stabilized or changing nightly features.
PR created automatically by Jules for task 3859093713268396088 started by @jac3km4