Skip to content

Implement TDBID ToStringDEBUG - #89

Open
Roms1383 wants to merge 6 commits into
jac3km4:masterfrom
Roms1383:feat/tdbid-to-string-debug
Open

Implement TDBID ToStringDEBUG#89
Roms1383 wants to merge 6 commits into
jac3km4:masterfrom
Roms1383:feat/tdbid-to-string-debug

Conversation

@Roms1383

Copy link
Copy Markdown
Contributor

Add support for gamedataTDBIDHelper#ToStringDEBUG and impl Display for TweakDbId.

@Roms1383

Copy link
Copy Markdown
Contributor Author

One optional thing to avoid forcing conditional compilation for to_string_debug on downstream plugins
is to create a test only variant for InvokeError:

#[cfg(test)]
#[cfg_attr(test, error("unsupported in this context: {0}"))]
UnsupportedContext(&'static str),

And have to_string_debug returns it automatically on #[cfg(test)].
Not sure how much you like this approach @jac3km4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant