chore: reliable workflow linting via lint-workflows.sh (#81)#82
Merged
Conversation
Default actionlint hangs on dependency-safety.yml's large inlined block; the wrapper runs 'actionlint -shellcheck= -pyflakes=' so structural linting completes deterministically. Stub-based bats test proves the non-hanging mode is invoked. Refs #81
Adds a 'Validating workflow changes' section listing the local checks and explaining why default actionlint hangs on dependency-safety.yml. Refs #81
Documents the reliable workflow-lint command, why default actionlint hangs on the inlined reusable workflow, and that ShellCheck is a separate layer. Refs #81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
scripts/lint-workflows.sh, a thin actionlint wrapper that always runs theknown non-hanging mode (
actionlint -shellcheck= -pyflakes= .github/workflows/*.yml),plus a stub-based bats test and docs in
README.mdand.claude/CLAUDE.md.Default
actionlinthangs on.github/workflows/dependency-safety.ymlbecause itslarge inlined
Scan and reportblock interacts badly with actionlint's ShellCheckorchestration. The hang is a tool limitation, not a workflow syntax error, and is
pre-existing on
main(not introduced by #80).What this does / does not change
./scripts/lint-workflows.shshellcheck scripts/*.sh) with known findingsdependency-safety.ymlINLINE_PAIRS/ inline-sync changeVerification
bats tests/green (215 tests, incl. 6 new)./scripts/lint-workflows.shcompletes in ~0.01s, exit 0 (real actionlint 1.7.12, no hang)shellcheck scripts/lint-workflows.shclean./scripts/check-inline-sync.shand./scripts/lint-workflow-call.shstill passFixes #81.