Fix Patrol finding: patrol-input-denylist-blocks-ld-preload-but-a7992e117a - #1237
Open
ivankuznetsov wants to merge 1 commit into
Open
Conversation
Optional workflow input names only rejected LD_LIBRARY_PATH and LD_PRELOAD individually, so other Linux dynamic-linker control surfaces such as LD_AUDIT, LD_PROFILE, and LD_DEBUG_OUTPUT passed InputName.valid? and reached managed child environments. Mirror the existing DYLD_ prefix guard with an LD_ prefix in RESERVED_PREFIXES and add a regression test covering the Linux loader env family.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patrol Fix
This pull request repairs one finding tracked by Hive's Patrol Fix workflow.
Sources
Finding evidence
Independent review
The exact patch closes the reported Linux loader environment gap by reserving the complete LD_ namespace through the existing shared input-name boundary. The broad validation failure is confined to unchanged agent-cli-runtime executable resolution and reproduces independently, while changed-boundary tests and lint pass.
Validation
Verdict: failed