Add warning about missing device path#71
Merged
Conversation
emiloh
approved these changes
Nov 2, 2025
emiloh
left a comment
emiloh
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, and much needed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR include?
Based on great user feedback, I think it is about time that we make sure that the program does not crash if the users haven't had the chance to create a configuration secret for our extension yet. PR adds a check of whether the path is added to the configuration or not.
If a device path has not been provided then we will make sure to let the user know and wait with the registration of the
NVMEFileSystem.