Skip to content

fix oob slice-index read in ihevcd_sao_shift_ctb#142

Open
SABITHSAHEB wants to merge 1 commit into
ittiam-systems:mainfrom
SABITHSAHEB:sao-neg-slice-idx-read
Open

fix oob slice-index read in ihevcd_sao_shift_ctb#142
SABITHSAHEB wants to merge 1 commit into
ittiam-systems:mainfrom
SABITHSAHEB:sao-neg-slice-idx-read

Conversation

@SABITHSAHEB

Copy link
Copy Markdown
Contributor
  1. for a 16x16 CTB at the left picture edge (i4_ctb_x == 1) in the chroma edge-offset path, ctbx_tl_t and ctby_tl_t stay 0, so au4_idx_tl[4] = pu1_slice_idx[(ctbx_tl_t - 1) + (ctby_tl_t * i2_pic_wd_in_ctb)] reads pu1_slice_idx[-1], out of bounds of pu1_pic_slice_map.
  2. the i4_ctb_x == 1 branch already sets au4_idx_tl[4] to the -1 sentinel, so only recompute it from the neighbor when ctbx_tl_t > 0.

Reachable on a multi-slice stream with 16x16 CTBs and chroma edge-offset SAO; the earlier -1 guards on au4_idx_tl[5]/[6] left this index read uncovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant