chore(infra): add turbosnap#1344
Conversation
|
size-limit report 📦
|
| "prestorybook:wc:dev": "yarn storybook:setup", | ||
| "storybook:wc:dev": "yarn prestorybook:wc:dev && concurrently \"yarn:storybook:wc:start\" \"yarn:watch:styles\" --raw --kill-others", | ||
| "storybook:wc:build": "storybook build -c .storybook/wc -o .storybook-static/wc", | ||
| "storybook:wc:build": "storybook build --webpack-stats-json -c .storybook/wc -o .storybook-static/wc", |
There was a problem hiding this comment.
Is this so it knows what pieces have changed?
There was a problem hiding this comment.
Yeah, I didn't know about this but the output from the first commit's failure of the Chromatic job directed me to add it. Locally run, it contains an array with a bunch of items like the following:
{
"modules": [
...,
{
"id": "./packages/pharos/src/components/combobox/pharos-combobox.wc.stories.ts",
"name": "./packages/pharos/src/components/combobox/pharos-combobox.wc.stories.ts",
"reasons": [
{
"moduleName": "/virtual:/@storybook/builder-vite/storybook-stories.js"
}
]
},
...
]
}|
Hmm, I would've hoped #1345 would trigger and catch a change to the alert 😖 |
|
The issue with TurboSnap detecting changes is ultimately related to the fact that Vite can't properly infer the dependency tree because in story files we use the registered custom element tags (e.g. Possible avenues:
|
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
We have a lot of components. We are very cross-browser. We don't want to build so many things. TurboSnap makes it faster and cheaper to test Storybook by testing only changed components.
How does this change work?
Add the config for TurboSnap to the Chromatic workflow
Additional context
Docs