fix(wall): neutral energy fluxes use energy type (W.m^-2), not particle type#273
Open
Simon-McIntosh wants to merge 1 commit into
Open
Conversation
…le type energy_fluxes kinetic/recombination neutral referenced wall_description_ggd_particle_neutral (m^-2.s^-1); retarget to the existing wall_description_ggd_energy_neutral (W.m^-2).
Simon-McIntosh
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
July 9, 2026 05:05
simpla-fusion
approved these changes
Jul 9, 2026
SimonPinches
approved these changes
Jul 9, 2026
DavidPCoster
approved these changes
Jul 9, 2026
imbeauf
approved these changes
Jul 15, 2026
medvedevsyu
approved these changes
Jul 15, 2026
hrdoktorx
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272.
The
energy_fluxeskineticandrecombinationstructures reached their neutral fluxes throughwall_description_ggd_particle_neutral, so neutral energy fluxes inherited the particle-flux unitm^-2.s^-1instead ofW.m^-2(theelectrons/ionsiblings already resolve to energy types). This retargets bothneutralelements to the existing-but-unreferencedwall_description_ggd_energy_neutral(W.m^-2).Scope:
energy_fluxes/{kinetic,recombination}/neutral,incident+emitted, bare and/state— 8 leaves. Wired to the particle unit since the paths were introduced in v3.38.0 (verified via the DD version history — no units change recorded since, so every release v3.38.0 → v4.1.1 and develop is affected). Metadata-only correction — the stored values were always energy fluxes.Backward-compatible, units-only.
wall_description_ggd_energy_neutralis structurally identical towall_description_ggd_particle_neutral: same children (element,name,ion_index,incident,emitted,multiple_states_flag,state) and the same state fields (name,vibrational_level,vibrational_mode,neutral_type,electron_configuration,incident,emitted). The only differences are theincident/emittedunits(W.m^-2vsm^-2.s^-1) and the correct energy type-level documentation. No field is added or removed —z_min/z_maxare ion-only (*_ion_state) and appear on neither neutral type.