Static HTML diffs#246
Conversation
093a709 to
94f4f10
Compare
94f4f10 to
ca30867
Compare
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
A couple of comments, let me know if you want to discuss them
| if (regex.test(body)) { | ||
| body = body.replace(regex, contentBlock); | ||
| console.log("Existing XML Diff block found and updated."); | ||
| } else { | ||
| body = body ? `${body}\n\n${contentBlock}` : contentBlock; | ||
| console.log("XML Diff block added to the end of the PR description."); | ||
| } |
There was a problem hiding this comment.
Could we get race conditions with the workflow from ReadTheDocs?
There was a problem hiding this comment.
I've added a 10 second waiting function to wait for the read the docs workflow to complete. Let me know what you think
There was a problem hiding this comment.
Hmm, looks a bit complicated... Could we integrate this link with the workflow for RTD instead?
There was a problem hiding this comment.
As just discussed in the DD progress meeting, ITER'd like to keep this one around for a bit longer.
Could you un-remove it please?
| --content-type "text/html" \ | ||
| --auth-mode key | ||
| - name: Check and wait for readthedocs (Max 10s) | ||
| id: check-workflows |
There was a problem hiding this comment.
Why the extra indentation here? Shouldn't these lines line-up under name ?
| id: check-workflows | |
| id: check-workflows |
3 participants
Generates HTML diffs for every created PR.
Example: https://scdimasdictionnarysa.z6.web.core.windows.net/
📚 Documentation preview 📚: https://imas-data-dictionary--246.org.readthedocs.build/en/246/