Open
Conversation
naegelejd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started as a simple fix to the conda package builds. This library is pure Python so there's no need to build and publish platform-specific conda packages, and as long as we do, we need to publish for every possible platform/arch.
In the process, I discovered that the recent bump to
xsdata==26.1introduced breaking changes in theismrmrd.xsd.ismrmrdHeaderAPI.So we need to release a new minor version (v1.15.0). To do that, this library should really be synchronized with ISMRMRD v1.15.0.
This PR does just that: Aligns the Python library with the C++ ismrmrd v1.15.0 API and hardens the
build/packaging infrastructure.
See CHANGELOG.md for the full list of changes, including
breaking changes.