fix(hub): Grok TUI overlays, web folder browse, slash completeness - #3
fix(hub): Grok TUI overlays, web folder browse, slash completeness#3ngav1491 wants to merge 2 commits into
Conversation
Passthrough the cursor-hide filter for Grok so alt-screen pickers (/resume, /history, /help) render in the Hub xterm instead of blanking. Add a web directory browser when native pick-directory is unavailable (remote Linux / no zenity). Expand Grok slash-command docs, prefer non-empty chat_history matches for /api/grok-history, and improve chat/history-lite i18n fallbacks. Operator-verified: /resume lists prior sessions; /history shows prompts.
…-browse fix(hub): Grok TUI overlays, web folder browse, slash completeness
|
Hi @ngav1491, thank you very much for this contribution! 🙏 The fixes look really valuable — Grok picker passthrough, remote spawn folder browser, and the expanded slash table all address real pain points, and the fact that you already validated them on your fork is much appreciated. Release plan We are currently in the release-freeze window for v0.5.1 (tag going out shortly), so I would like to review and merge this PR for v0.5.2 rather than rushing it into v0.5.1. This lets me give the ~+900 line diff (especially Timeline target: v0.5.2 review starts within ~1 week after v0.5.1 ships. One request — could you rebase onto This repo uses a
…that would make the review and merge straightforward. If rebasing is inconvenient, no problem — I can also cherry-pick the commits manually, just let me know. Thanks again for the careful write-up and the tested checklist — it makes review much easier. Looking forward to landing this in v0.5.2! @ngav1491 さん、素晴らしい貢献をありがとうございます!🙏 Grok picker の passthrough、リモート spawn のフォルダブラウザ、slash table 拡充、いずれも実際に困っていた箇所で、fork 側で既に検証まで済ませていただいている点も本当に助かります。 リリース計画について 現在ちょうど v0.5.1 のリリースフリーズ期間に入っており(近日中にタグ push 予定)、この PR は v0.5.1 に押し込むのではなく v0.5.2 でのレビュー・マージとさせてください。約 900 行の差分(特に 目安: v0.5.1 リリース後、約 1 週間以内に v0.5.2 のレビュー開始予定です。 1 点お願い — base を 本リポジトリは
をお願いできると助かります。rebase が難しい場合はこちらで手動 cherry-pick しますので、その旨コメントください。 丁寧な PR 説明とテストチェックリスト、大変助かります。v0.5.2 でお目にかかるのを楽しみにしています! |
|
Quick follow-up: v0.5.1 just shipped 🎉 — and it includes your Vietnamese localization from PR #2 as an officially released feature!
Users installing v0.5.1 via This PR (#3) is still on track for v0.5.2 review as I mentioned earlier — no change to that plan. Whenever you get a chance to rebase onto 補足です: v0.5.1 をリリースしました 🎉 — PR #2 のベトナム語ローカライズが正式機能として同梱されています!
この PR #3 は先ほどお伝えしたとおり v0.5.2 でのレビュー予定に変更ありません。 |
|
Thank you for PR #3. I reviewed it carefully and decided to adopt the useful parts selectively rather than merge the PR as a whole. I will adopt:
I will not adopt the change in The reason is that many-ai-cli currently does not have an exact Grok-internal session ID to correlate with a Hub session. The matching is inferred from the working directory and timestamps. If the nearest candidate is an empty stub, choosing a farther candidate with more messages may display a different conversation. That would turn “no history” into “possibly the wrong history,” which is a correctness risk. This is also not a failure of Grok itself. It only affects the optional many-ai-cli Chat-tab history viewer; Grok's native The PR is not being rejected as a whole—thank you for the fixes. The clearly scoped Grok TUI, remote folder browsing, and slash-command improvements are the parts I intend to carry forward. |
Summary
Cross-fork PR from
ngav1491/many-ai-cli(already merged as PR #1 on the fork)./resume//history//helpblank pickers: passthrough the Hub xterm cursor-hide filter forprovider === 'grok'so CUP-heavy alt-screen overlays are no longer discarded (same class as prior OpenCode picker bugs).env_kind: remote), open an in-browser directory browser via/api/list-subdirs.resources/slash-commands/grok.md(includes/history,/context,/fork, …).i18n-ready; English fallbacks; web-dir browser strings (en/ja/vi).Commits
a2e9b67fix(hub): Grok TUI overlays, web folder browse, slash completeness54de2e6Test plan
/resumelists prior sessions for same cwd/historyshows prompt history after session has promptsgo test ./internal/hub/ -run 'Grok|FindGrok|ChatHistory'/resumeand/historygrok sessions liststill lists disk sessions (control)Notes
grok sessions listalready had data; TUI picker was blanked by the display filter./history= current-session prompt search;/resume= session picker (or/resume <uuid>/many-ai-cli grok --resume <uuid>).