build: give make test the same per-test timeout as CI (#364) - #369
Merged
Conversation
CI already fails fast and names a wedged test; make test did not, so a hang on a developer machine looked like a slow suite and had to be killed by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364.
CI runs the suite with
-test-timeouts-enabled YES -maximum-test-execution-time-allowance 120, so a wedged test fails fast and is named.make testdid not, which is why a hang on a developer machine looked like a slow suite and had to be killed by hand after 40 minutes.With this, the last of #364 is covered:
NSRemoteViewcrash;