redesign(site): rebuild the landing page mobile-first with a restrained visual identity - #354
Open
isaaclins wants to merge 1 commit into
Open
redesign(site): rebuild the landing page mobile-first with a restrained visual identity#354isaaclins wants to merge 1 commit into
isaaclins wants to merge 1 commit into
Conversation
…ed visual identity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete redesign of the GitHub Pages site in
docs/, mobile and desktop.Why
On a real iPhone the old page was a desktop layout crammed into a phone: "Liked Songs", "Deep Focus", "Midnight Drive", "Lo-Fi Beats" and "Floating Points" each wrapped onto two lines, the now-playing title wrapped, and the bottom feature row was clipped mid-word.
The responsive layer was patches rather than design:
.heroforced todisplay:blockwithmax-width:100vw; overflow:hidden— suppressing overflow instead of fixing what overflowed.hero__copy/.hero__stagesized bywidth: calc(100vw - 2.2rem), redone at 480px with a magicmin(20.75rem, …).window__body{ grid-template-columns: minmax(118px, 42%) … }kept the desktop two-pane mockup on phones; at ~118px that sidebar cannot fit its own labelsThe root error: the app mockup was a desktop artifact being shrunk rather than reconsidered.
What changed
color-scheme: lightby default with aprefers-color-scheme: darkvariant.clamp()uses) rather than a ladder of viewport breakpoints.docs/, per the debt concerns in Tech-debt audit: the debt is 124 allowlisted exemptions and a 1064-line view, not the file tree #351.Verified
Objectively confirmed on this branch:
100vwarithmetic (was the sizing hack)overflow:hidden/overflow-x(was the overflow suppression)@containerqueries, 37clamp(), light-firstcolor-schemeRendered and read at ~574pt: hero, stats and CTA are clean, nothing wraps awkwardly, nothing clips.
I could not independently confirm the layout at a true 390px viewport. Arc enforces a minimum window width of 470pt and Safari 574pt, so neither browser can render a real iPhone viewport by window resizing alone. The agent reported 390px screenshots; that number should be treated as unconfirmed until checked in device emulation or on a real phone.
Given 390px is exactly the width that was broken before, please sanity-check this on your phone before merging.