Reactivate camera tests that were accidentally deactivated.

[alexmillane]

Summary

Reactivate camera tests that were accidentally deactivated.

Detailed description

• These were accidentally turned off in CI in Isolate subprocess tests. #617
• This restores the pre-Isolate subprocess tests. #617 behaviour
• I also shift the uv stuff nearer to the bottom of the ci file.

[arena-review-bot]

🤖 Isaac Lab-Arena Review Bot

Summary

This PR restores the with_cameras PhysX test step in the container test job that was accidentally dropped in #617, and relocates the uv_changes/uv_test jobs to the bottom of the file. The restoration is correct and its marker (with_cameras and not with_subprocess and not with_newton) matches the sibling no-camera step in the same job, so camera+Newton tests are not double-run there. The uv-job move is purely cosmetic — GitHub Actions orders by needs, not file position — and the anchors it relies on are all defined in pre_commit, so nothing breaks.

Findings

🔵 Improvement: .github/workflows/ci.yml:433 — The restored test-job camera step excludes with_newton, but the uv_test camera step does not. A test marked both with_cameras and with_newton would run twice in uv_test (Newton step + camera step). Minor and pre-existing, but this PR makes the two diverge — worth aligning them.

Test Coverage

N/A — this is a CI-config change. It re-enables an existing test phase rather than adding new code, which is exactly the intent.

Verdict

Ship it — the camera-test restoration is correct; the one marker note is optional.

[greptile-apps]

Greptile Summary

This PR restores the accidentally dropped "Run in-process PhysX tests with cameras" step to the main test CI job, and reorganizes the uv_changes/uv_test jobs to the bottom of the workflow file. The restored step correctly uses -m "with_cameras and not with_subprocess and not with_newton", matching the intent described in the existing code comments.

• The camera test step is added back to the test job at the right position (between "without cameras" and GR00T tests), with the correct pytest marker expression that excludes Newton and subprocess tests.
• The uv_changes and uv_test jobs are moved verbatim to after build_docs_pre_merge — their logic is unchanged, only their position in the file.
• The uv_test camera step retains a pre-existing marker inconsistency (lacks not with_newton), which could cause double-execution of any tests marked with both with_cameras and with_newton in that job.

Confidence Score: 4/5

Safe to merge — the change restores a previously working CI step and reorganizes job ordering without affecting logic.

The newly added camera step in test uses the correct marker expression, matching the surrounding steps' logic. The only issue found is a pre-existing inconsistency in the uv_test job's camera step that could cause duplicate test runs for tests with both with_cameras and with_newton markers.

.github/workflows/ci.yml — specifically the uv_test camera step at line 432, which is missing the not with_newton exclusion present in the restored test job step.

Important Files Changed

Filename	Overview
.github/workflows/ci.yml	Adds back the missing "Run in-process PhysX tests with cameras" step to the test job (with correct and not with_newton exclusion), and moves uv_changes/uv_test jobs from near the top to after build_docs_pre_merge for organizational purposes. The uv_test camera step retains a pre-existing marker inconsistency (missing not with_newton).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[pre_commit] --> B[test]
    A --> C[tests_with_subprocess]
    A --> D[test_gr00t_closedloop_e2e]
    A --> E[test_curobo_deps]
    A --> F[build_docs_pre_merge]
    A --> UV_CHG[uv_changes]
    UV_CHG --> UV_TEST[uv_test]

    B --> B1[Newton tests]
    B1 --> B2[PhysX without cameras]
    B2 --> B3[PhysX with cameras RESTORED]
    B3 --> B4[GR00T policy tests]

    UV_TEST --> UV1[Newton tests]
    UV1 --> UV2[PhysX without cameras]
    UV2 --> UV3[PhysX with cameras - missing not with_newton]
    UV3 --> UV4[Subprocess PhysX tests]

    B --> IMG[build_and_push_image_post_merge]
    E --> CUROBO[build_and_push_curobo_image_post_merge]
    B --> CUROBO

Loading

_{Reviews (1): Last reviewed commit: "Reactivate camera tests that were accide..." | Re-trigger Greptile}